Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceReference should not resolve to Chained parameter #35

Closed
mharthoorn opened this issue Jul 10, 2015 · 0 comments · Fixed by #281
Closed

ResourceReference should not resolve to Chained parameter #35

mharthoorn opened this issue Jul 10, 2015 · 0 comments · Fixed by #281
Labels
Projects

Comments

@mharthoorn
Copy link
Member

The following search
~/fhir/Encounter?patient=d1
resolves to normalized criteria {patient.internal_id=d1}
Where it should just resolve to {patient=Patient/d1}

Because the encounter should be found even if the patient is not present in the database.

@mharthoorn mharthoorn added the bug label Jul 10, 2015
@mharthoorn mharthoorn added this to the Spark 3.0 RC milestone Jul 10, 2015
@mharthoorn mharthoorn modified the milestones: Spark 3.1, Spark 3.0 RC Jul 21, 2015
@mbaltus mbaltus modified the milestones: Spark 3.3 - DevDays2015, Spark 3.1 Oct 19, 2015
@mharthoorn mharthoorn modified the milestone: Spark 12 - Montreal Aug 29, 2016
@mharthoorn mharthoorn assigned CorinaCiocanea and unassigned cknaap Aug 30, 2016
@mharthoorn mharthoorn added this to the Spark 13 - Baltimore milestone Aug 30, 2016
@kennethmyhra kennethmyhra removed this from the Spark - DevDays 2016 milestone Nov 7, 2019
@kennethmyhra kennethmyhra added this to To do in R2020.1 via automation Nov 14, 2019
@kennethmyhra kennethmyhra removed this from To do in R2020.1 Feb 16, 2020
@kennethmyhra kennethmyhra added this to To do in R2020.2 via automation Feb 16, 2020
@kennethmyhra kennethmyhra removed this from To do in R2020.2 Aug 5, 2020
@kennethmyhra kennethmyhra added this to To do in R2020.3 via automation Aug 16, 2020
@kennethmyhra kennethmyhra moved this from To do to In progress in R2020.3 Sep 19, 2020
andy-a-o added a commit to andy-a-o/spark that referenced this issue Sep 21, 2020
Alternative implementation that doesn't perform reference check when searching by references.

I made it enabled by default. It's also an option to disable it and return to the previous impl completely
or partially for the limited number of resources.

To return to the previous implementation having reference checks add this into `appsettings.json`:

```
   ...
    "SparkSettings": {
        ...
        "Search": {
            "CheckReferences": true
        }
    }
   ...
```

Or, in `Web.config`:

```
<add key="SearchCheckReferences" value="true" />
```

To partially enable reference check for the limited number of resources add this:

```
   ...
    "SparkSettings": {
        ...
        "Search": {
            "CheckReferences": true,
            "CheckReferencesFor": ["Encounter"] // Encounter is just an example
        }
    }
   ...
```

and finally to partially enable reference check on resource property level use this example:

```
   ...
    "SparkSettings": {
        ...
        "Search": {
            "CheckReferences": true,
            "CheckReferencesFor": ["Encounter.subject", "Encounter.participant"]
        }
    }
   ...
```

Here's the `Web.config` analogue:

```
<add key="SearchCheckReferences" value="Encounter.subject,Encounter.participant" />
```

NOTE: index rebuild may be required if using absolute local URLs for storing references.
@kennethmyhra kennethmyhra moved this from In progress to Review in progress in R2020.3 Sep 22, 2020
R2020.3 automation moved this from Review in progress to Done Sep 24, 2020
kennethmyhra added a commit that referenced this issue Sep 24, 2020
ResourceReference should not resolve to Chained parameter #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
R2020.3
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants