3048 Move working with modes to parsers - #3070
Merged
Merged
Conversation
…ngine, FhirJsonConver) can be simplified.
Kasdejong
reviewed
Mar 4, 2025
Kasdejong
left a comment
Kasdejong
left a comment
Member
There was a problem hiding this comment.
Set to approve, just worried about how many people might use the assembly to construct their parsers. It is public, correct?
…parsers' into 3048-move-working-with-modes-to-parsers
ewoutkramer
enabled auto-merge
March 4, 2025 12:42
Kasdejong
approved these changes
Mar 4, 2025
This was referenced Oct 15, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Aug 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3049.
Using with fixed desserialization modes was something we invented for FhirSerilizationEngines, but it turned out we really liked the concept to be useable for creating parsers in general and also for the FhirJsonConverter. To make this possible, I did the following:
Since I originally started out working on #3049, there are some (minor) changes in this PR that actually are part of the future #3049.