Skip to content

Remove code marked as Obsolete #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ewoutkramer merged 7 commits into from
Jan 16, 2025
Merged

Remove code marked as Obsolete #3010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a7c21e2
Remove obsoletes
andrzejskowronski Jan 14, 2025
ae3c1e7
Mark remaining sync extension methods of FhirClient as obsolete
andrzejskowronski Jan 14, 2025
acf3d67
Mark methods internal
andrzejskowronski Jan 14, 2025
ad0fe24
Cleanup test
andrzejskowronski Jan 14, 2025
bf1d28e
Remove unnecessary copies of tests
andrzejskowronski Jan 14, 2025
bd7866a
Generate suppressions
andrzejskowronski Jan 15, 2025
0940db0
Parametrize test
andrzejskowronski Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
703 changes: 656 additions & 47 deletions src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions src/Hl7.Fhir.Base/ElementModel/TypedElementParseExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static class TypedElementParseExtensions

/// <inheritdoc cref="ParseBindable"/>
[Obsolete("WARNING! Intended for internal API usage exclusively")]
public static Element? ParseBindableInternal(this ITypedElement instance)
internal static Element? ParseBindableInternal(this ITypedElement instance)
{
return instance.InstanceType switch
{
Expand Down Expand Up @@ -87,7 +87,7 @@ public static Quantity ParseQuantity(this ITypedElement instance)
#pragma warning restore CS0618 // Type or member is obsolete

[Obsolete("WARNING! Intended for internal API usage exclusively")]
public static Quantity ParseQuantityInternal(this ITypedElement instance)
internal static Quantity ParseQuantityInternal(this ITypedElement instance)
{
var newQuantity = new Quantity
{
Expand All @@ -112,7 +112,7 @@ public static Quantity ParseQuantityInternal(this ITypedElement instance)
#pragma warning restore CS0618 // Type or member is obsolete

[Obsolete("WARNING! Intended for internal API usage exclusively")]
public static T ParsePrimitiveInternal<T>(this ITypedElement instance) where T : PrimitiveType, new()
internal static T ParsePrimitiveInternal<T>(this ITypedElement instance) where T : PrimitiveType, new()
=> new() { ObjectValue = instance.Value };

#endregion
Expand All @@ -125,7 +125,7 @@ public static Coding ParseCoding(this ITypedElement instance)


[Obsolete("WARNING! Intended for internal API usage exclusively")]
public static Coding ParseCodingInternal(this ITypedElement instance)
internal static Coding ParseCodingInternal(this ITypedElement instance)
{
return new Coding()
{
Expand All @@ -145,7 +145,7 @@ public static ResourceReference ParseResourceReference(this ITypedElement instan
#pragma warning restore CS0618 // Type or member is obsolete

[Obsolete("WARNING! Intended for internal API usage exclusively")]
public static ResourceReference ParseResourceReferenceInternal(this ITypedElement instance)
internal static ResourceReference ParseResourceReferenceInternal(this ITypedElement instance)
{
return new ResourceReference()
{
Expand All @@ -162,7 +162,7 @@ public static CodeableConcept ParseCodeableConcept(this ITypedElement instance)
#pragma warning restore CS0618 // Type or member is obsolete

[Obsolete("WARNING! Intended for internal API usage exclusively")]
public static CodeableConcept ParseCodeableConceptInternal(this ITypedElement instance)
internal static CodeableConcept ParseCodeableConceptInternal(this ITypedElement instance)
{
return new CodeableConcept()
{
Expand Down
4 changes: 0 additions & 4 deletions src/Hl7.Fhir.Base/FhirPath/Parser/Lexer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,6 @@ from fraction in Parse.Number
from _ in Parse.Char('$')
from name in Parse.String("this").XOr(Parse.String("index")).Or(Parse.String("total")).Text()
select name;

[Obsolete("This lexer is no longer used by the fhirpath parser as it processes the tokens correctly", false)]
public static readonly Parser<string> Quantity =
Parse.Regex(P.Quantity.QUANTITYREGEX);
}


Expand Down
6 changes: 0 additions & 6 deletions src/Hl7.Fhir.Base/Introspection/ClassMapping.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,6 @@ private ClassMapping(string name, Type nativeType, FhirRelease release)
/// </summary>
public Type? EnumType { get; private init; }

/// <summary>
/// Indicates whether this class represents the nested complex type for a backbone element.
/// </summary>
[Obsolete("These types are now generally called Backbone types, so use IsBackboneType instead.")]
public bool IsNestedType { get => IsBackboneType; set => IsBackboneType = value; }

/// <summary>
/// Indicates whether this class represents the nested complex type for a backbone element.
/// </summary>
Expand Down
8 changes: 0 additions & 8 deletions src/Hl7.Fhir.Base/Model/SearchParamDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ private string DebuggerDisplay
public Markdown? Description { get; set; }
public SearchParamType Type { get; set; }

/// <summary>
/// If this search parameter is a Composite, this array contains
/// the list of search parameters the param is a combination of <seealso cref="Component"/>
/// </summary>
[Obsolete("Use the property Component instead. " +
"Obsolete since 2023-05-16. Will be removed in the next major release.")]
public string[]? CompositeParams { get; set; }

/// <summary>
/// One or more paths into the Resource instance that the search parameter
/// uses
Expand Down
Loading