Skip to content

6.0/2923 Make serialization use new serializers - #3002

Merged
ewoutkramer merged 12 commits into
develop-6.0from
6.0/2923-make-serialization-use-new-serializers
Jan 13, 2025
Merged

6.0/2923 Make serialization use new serializers#3002
ewoutkramer merged 12 commits into
develop-6.0from
6.0/2923-make-serialization-use-new-serializers

Conversation

@ewoutkramer

@ewoutkramer ewoutkramer commented Jan 6, 2025

Copy link
Copy Markdown
Member

Fixes #2923.

⚠️ This PR cleans up the serialization API, mostly getting rid of similar but different serializer settings. This is probably one of the biggest batches of changes to the public surface, so it has its own section here: https://github.com/FirelyTeam/firely-net-sdk/wiki/Breaking-changes-in-6.0#breaking-changes-to-the-serializers

I have not yet done some renames because it would make reviewing harder. So after review, this still needs to be done:

  • Rename CommonFhirXml/JsonSerializer -> BaseFhirXml/JsonSerializer
  • CommonFhirXml/JsonSerializerExtensions -> Xml/JsonSerializerExtensions
  • Of course, rename the files.

@ewoutkramer ewoutkramer changed the title 6.0/2923 make serialization use new serializers 6.0/2923 Make serialization use new serializers Jan 8, 2025
Made the obsolete Newtonsoft function work via the new serializers
Removed subsetting functions from the POCO surface.
@ewoutkramer
ewoutkramer marked this pull request as ready for review January 9, 2025 10:37
@ewoutkramer
ewoutkramer enabled auto-merge January 9, 2025 10:37
@ewoutkramer
ewoutkramer requested a review from mmsmits January 9, 2025 10:38
@ewoutkramer
ewoutkramer requested a review from mmsmits January 10, 2025 16:00
@ewoutkramer

ewoutkramer commented Jan 10, 2025

Copy link
Copy Markdown
Member Author

I have now documented all serialization functions and extensions, as requested verbally by @mmsmits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants