Moved SearchParamDefinition from STU3+ to a separate class in Base. - #2987
Merged
mmsmits merged 6 commits intoDec 9, 2024
Merged
Conversation
ewoutkramer
marked this pull request as ready for review
December 4, 2024 13:38
Member
|
maybe a PR description? I'll review regardless :) |
Member
Author
|
working on it. |
Member
|
fixes #2531 |
mmsmits
enabled auto-merge
December 5, 2024 09:10
Kasdejong
approved these changes
Dec 5, 2024
…on-to-base # Conflicts: # src/Hl7.Fhir.R4B/CompatibilitySuppressions.xml # src/Hl7.Fhir.R5/CompatibilitySuppressions.xml
…te-searchparam-definition-to-base
This was referenced Oct 15, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Aug 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchParamDefinition used to be in the sattelites, since it has a
Targetelement that was bound to ResourceTypes. Now, with the publication of R5, we have a "version independent" list of resources, so by using this enum we are able to move SearchParamDefinition out to the Base assembly.This also required some changes to code generation, which need to be review as well: FirelyTeam/fhir-codegen#49.
Since the SPD class was nested in ModelInfo (which is in the sattellites), I needed to move this class out of ModelInfo, which is a breaking change as well.
Breaking changes
ModelInfo.SearchParamDefinitionis moved out ofModelInfoand now lives in the assembly root namespace.Targetis changed fromResourceTypetoVersionIndependentResourceTypesAll.VersionIndependentResourceTypesAllis moved from R5 to the Base assembly.