Some renames to types that were incorrect. - #2986
Merged
Merged
Conversation
mmsmits
self-requested a review
December 5, 2024 09:12
mmsmits
approved these changes
Dec 5, 2024
mmsmits
enabled auto-merge
December 5, 2024 09:31
This was referenced Oct 15, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Aug 5, 2026
This was referenced Aug 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen had some code to keep on generating divergent names for enums, components, types etcetera, which were once generated in error but that we could not correct until we are publishing a new major release. Now is the time.
This PR contains the result of re-running codegen with some of the improved names for the types.
Breaking changes
Narrative.divandNarrative.statusare no longer in-summary (this has been corrected in later versions of the spec, but was not yet reflected in the generated code). This will result in a different rendering of resources when generating summaries!\CitedArtifactContributorshipSummaryComponenthas been renamed to the more correctContributorshipSummaryComponent.