Remove Children, NamedChildren and IDictionary - #2973
Merged
Conversation
Kasdejong
changed the title
Kasdejong
requested changes
Nov 20, 2024
Kasdejong
left a comment
Kasdejong
left a comment
Member
There was a problem hiding this comment.
We should document the removal of AsReadOnlyDictionary in the wiki pages. Apart from that, no comments.
# Conflicts: # src/Hl7.Fhir.Base/Model/Base.cs # src/Hl7.Fhir.Support.Tests/Serialization/TestDictionaryImplementation.cs
ewoutkramer
enabled auto-merge
November 20, 2024 21:57
Kasdejong
approved these changes
Nov 22, 2024
This was referenced Oct 15, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Aug 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Changes
In our effort to simplify, this PR removes three ways to navigate down the tree:
This also makes sure none of our code is dependent on IDictionary anymore, and we are using "Base" (or ITypedElement) instead to navigate.
Fixes #2927.