Refactored FhirPath engine to work against IScopedNode - #2964
Merged
Conversation
Kasdejong
commented
Nov 13, 2024
Kasdejong
marked this pull request as ready for review
November 13, 2024 18:15
ewoutkramer
approved these changes
Nov 18, 2024
Member
Author
|
I'm assuming I can mark the conversations as resolved since you approved the PR @ewoutkramer? |
This was referenced Oct 15, 2025
This was referenced Nov 24, 2025
This was referenced Aug 5, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The FhirPath engine now works against IScopedNode
Related issues
#2915
Testing
All existing FP tests are running except for a few cases of polymorphism. These are ignored for now in wait of refactoring against Base.
Breaking changes
Refactored most signatures in the internals of the FP engine to use IScopedNode instead of ITypedElement. Surface API remains unchanged (through extension methods on ITE and Base), apart from changes to the FhirEvaluationContext fields.