Skip to content

Base POCO parsers/serializers on POCO, not IROD - #2950

Merged
ewoutkramer merged 8 commits into
develop-6.0from
6.0/parse-elements-for-xml-parsers
Nov 13, 2024
Merged

Base POCO parsers/serializers on POCO, not IROD#2950
ewoutkramer merged 8 commits into
develop-6.0from
6.0/parse-elements-for-xml-parsers

Conversation

@ewoutkramer

@ewoutkramer ewoutkramer commented Oct 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • ⚠️ BREAKING: Based the parsers/serializers on Base instead of IReadOnlyDictionary<>. Should not really matter, since internally, the code required the things to be subclasses of Base anyway to function correctly.
  • Added extensions so subtrees van be serialized, if the underlying engine is our new POCO serializer
  • Added extensions so one can serialize to/from streams, if the underlying engine is our new POCO serializer.
  • ⚠️ BREAKING: Removed the obsolete FhirJsonConverter constructors (use the ForFhir extension methods on JsonSerializerOptions).
  • ⚠️ BREAKING: Renamed methods on the IFhirSerializationExtensions, since they made no sense (e.g. DeserializeReaderToJson has become DeserializeFromJsonReader).

Fixes #2917.

@ewoutkramer
WIP
2d8a0d2
@ewoutkramer
Merge remote-tracking branch 'origin/move-to-netstandard-2.1' into 6.…
b7e8886 
…0/parse-elements-for-xml-parsers
@ewoutkramer
Base parsers on POCO, not IROD. Also, improve XML subtree serialization.
a5736b5
@ewoutkramer
Merge branch 'develop-6.0' into 6.0/parse-elements-for-xml-parsers
d0ba6ad 
# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
@ewoutkramer
Merge branch 'develop-6.0' into 6.0/parse-elements-for-xml-parsers
26f0190 
# Conflicts:
#	src/Hl7.Fhir.Base/CompatibilitySuppressions.xml
#	src/Hl7.Fhir.Base/Serialization/BaseFhirJsonPocoSerializer.cs
#	src/Hl7.Fhir.Base/Serialization/FhirJsonConverter.cs
ewoutkramer
ewoutkramer commented Oct 23, 2024
View reviewed changes
Comment thread src/Hl7.Fhir.Base/Serialization/BaseFhirJsonPocoSerializer.cs Outdated
@ewoutkramer ewoutkramer mentioned this pull request Oct 23, 2024
Closed
@ewoutkramer
ewoutkramer requested a review from Kasdejong October 23, 2024 17:17
Kasdejong
Kasdejong reviewed Oct 24, 2024
View reviewed changes
Comment thread src/Hl7.Fhir.Base/Serialization/FhirXmlBuilderExtensions.cs
Comment thread src/Hl7.Fhir.Base/Serialization/FhirXmlBuilderExtensions.cs
Kasdejong
Kasdejong requested changes Oct 24, 2024
View reviewed changes

@Kasdejong Kasdejong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally set the review to "comment" instead of "request changes", this should tag it appropriately

@ewoutkramer
ewoutkramer merged commit e169b06 into develop-6.0 Nov 13, 2024
@ewoutkramer
ewoutkramer deleted the 6.0/parse-elements-for-xml-parsers branch November 13, 2024 14:54
This was referenced Oct 15, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Nov 24, 2025
Closed
Closed
This was referenced Dec 1, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 15, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Jan 19, 2026
Closed
This was referenced Aug 5, 2026
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kasdejong Kasdejong Kasdejong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ewoutkramer @Kasdejong