Repository navigation
Remove all non-inheritable extensions from the base profile before snapshotting #2886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
6d5ad14
f22faf9
6da124f
71bfd26
33f2e70
7244bd9
604abd7
3eee269
806545e
cbcd50e
016e7b0
40f323b
3d2a6ed
16c9577
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:Hl7.Fhir.Specification.Snapshot.SnapshotGeneratorExtensions</Target> | ||
| <Left>lib/net8.0/Hl7.Fhir.Conformance.dll</Left> | ||
| <Right>lib/net8.0/Hl7.Fhir.Conformance.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:Hl7.Fhir.Specification.Snapshot.SnapshotGeneratorExtensions</Target> | ||
| <Left>lib/netstandard2.0/Hl7.Fhir.Conformance.dll</Left> | ||
| <Right>lib/netstandard2.0/Hl7.Fhir.Conformance.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:Hl7.Fhir.Specification.Snapshot.SnapshotGeneratorExtensions</Target> | ||
| <Left>lib/net8.0/Hl7.Fhir.STU3.dll</Left> | ||
| <Right>lib/net8.0/Hl7.Fhir.STU3.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:Hl7.Fhir.Specification.Snapshot.SnapshotGeneratorExtensions</Target> | ||
| <Left>lib/netstandard2.0/Hl7.Fhir.STU3.dll</Left> | ||
| <Right>lib/netstandard2.0/Hl7.Fhir.STU3.dll</Right> | ||
| <IsBaselineSuppression>true</IsBaselineSuppression> | ||
| </Suppression> | ||
| </Suppressions> |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,8 @@ | |
| using Hl7.Fhir.Support; | ||
| using Hl7.Fhir.Utility; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
| using System; | ||
| using NSubstitute; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using System.IO; | ||
|
|
@@ -2433,8 +2433,8 @@ private static bool isAlmostExactly(ElementDefinition elem, ElementDefinition ba | |
| } | ||
|
|
||
| // Also ignore any Changed extensions on base and diff | ||
| elemClone.RemoveAllConstrainedByDiffExtensions(); | ||
| baseClone.RemoveAllConstrainedByDiffExtensions(); | ||
| elemClone.RemoveAllNonInheritableExtensions(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this method replace the original ones? So RemoveallNonInheritableExtension replaces RemoveAllConstrainedByDiffExtensions? If so, should we not remove/obsolete the original method?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I thought about that, but didn't dare to since Forge might be using the ConstraintByDiff extension one maybe?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Forge does not use the RemoveAllConstrainedByDiffExtensions extension.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, I'll Obsolete is then
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about http://hl7.org/fhir/StructureDefinition/elementdefinition-bindingName? I see that one all the time as well.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not on the list: |
||
| baseClone.RemoveAllNonInheritableExtensions(); | ||
| elemClone.RemoveAllConstrainedByDiffAnnotations(); | ||
| baseClone.RemoveAllConstrainedByDiffAnnotations(); | ||
|
|
||
|
|
||

Uh oh!
There was an error while loading. Please reload this page.