Fixed element definition element.id not being merged by the snapshot generator - #2884
Merged
Conversation
ewoutkramer
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added merging of element id to the snapshot generator
Related issues
Fixes issue #2839
Testing
Added unit test ElementDefinitionPropertyElementIdTest for STU3 and RX
Note that for STU3 one test case is not handled correctly by the snapshot generator.
This has been documented with a comment.
This is because the logic in STU3 for merging types is different (simpler) than R4 and later.
To correct this, the RX logic should be backported to STU3.
FirelyTeam Checklist