Fix #7548 - SET BIND OF TIMESTAMP WITH TIME ZONE TO CHAR is not working with UTF8 connection charset. #7549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with UTF8 connection charset.
|
Can we have non-ascii characters in TZ name? If not may be better force use of ASCII charset to coerced fields. |
I thought on it but it looks very invasive to change the charset, specially thinking on the fix for v4. Even it being ascii-only, our last pass generally is to convert things for the connection charset and that would not be done in this case. |
AlexPeshkoff
approved these changes
Apr 17, 2023
asfernandes
added a commit
that referenced
this pull request
Apr 18, 2023
…ng with UTF8 connection charset. (#7549)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.