Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Windows, engine may hung when works with corrupted database and read after the end of file #6968

Closed
hvlad opened this issue Sep 14, 2021 · 1 comment
Closed

On Windows, engine may hung when works with corrupted database and read after the end of file #6968

hvlad opened this issue Sep 14, 2021 · 1 comment
Assignees
@hvlad
Labels
affect-version: 4.0.0 affect-version: 5.0 Initial fix-version: 4.0.1 fix-version: 5.0 Beta 1 qa: covered by another tests type: bug

Comments

@hvlad
Copy link
Member

hvlad commented Sep 14, 2021

GetOverlappedResult() should not be called when read\write failed and was completed synchronously.
I.e. we must always check for ERROR_IO_PENDING error before call GetOverlappedResult().

See also #6747 as a case when such hung could happen.
@hvlad hvlad self-assigned this Sep 14, 2021
hvlad added a commit that referenced this issue Sep 14, 2021
@hvlad
Fixed bug #6968 : On Windows, engine may hung when works with corrupt…
1be11ef 
…ed database and read after the end of file
hvlad added a commit that referenced this issue Sep 14, 2021
@hvlad
Fixed bug #6968 : On Windows, engine may hung when works with corrupt…
2f6291a 
…ed database and read after the end of file
@hvlad hvlad closed this as completed Sep 14, 2021
@pavel-zotov
Copy link

pavel-zotov commented Sep 19, 2021 •
edited
Loading

:::: test details ::::
Partially covered by core_2484.fbt (which checks that there is no more "Overlapped I/O operation is in progress").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
affect-version: 4.0.0 affect-version: 5.0 Initial fix-version: 4.0.1 fix-version: 5.0 Beta 1 qa: covered by another tests type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dyemanov @hvlad @pavel-zotov