feat(manufacturers): add manufacturer logo support#21
Closed
akira69 wants to merge 6 commits into
Closed
Conversation
Updated sections related to project support and recycling initiatives.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--> opened too soon, coming later :)
Summary
Adds manufacturer logo support to FilaMan as a standalone PR based on
main, without depending on the export or printing branches.This PR introduces:
Plan reference:
.copilot/logo-plan-pr857.mdWhy
FilaMan needed the non-print manufacturer logo behavior inspired by Spoolman PR 857, but the work should be independent from the unrelated filament export/printing changes.
This branch is intentionally based on
mainand contains only the logo-related work.Implementation
Backend
logo_urlandlogo_file_pathfields to manufacturers plus a migration.resolved_logo_urlresponse support.backend/alembic.inireliably regardless of launch cwd.Frontend
Code Quality Compliance ✅
backend/.venv/bin/python -m compileall appnpm run build{ url }payloadValidation
Completed:
Notes:
429 Too Many Requestsduring one smoke test run, so the success-path validation used a stable public image URL instead.Test Checklist