Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove the copied interface from tm-db #82

Merged
merged 2 commits into from
Dec 16, 2022
Merged

chore: remove the copied interface from tm-db #82

merged 2 commits into from
Dec 16, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Dec 16, 2022 •
edited
Loading

Description

I add the missing codes in the previous pr #77

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zemyblue zemyblue changed the title fix: remove the copied interface from tm-db chore: remove the copied interface from tm-db Dec 16, 2022
@zemyblue zemyblue requested review from shiki-tak, tnasu, loloicci and da1suk8 and removed request for shiki-tak and tnasu December 16, 2022 06:04
@zemyblue zemyblue self-assigned this Dec 16, 2022
@zemyblue zemyblue merged commit 8ac1c61 into Finschia:main Dec 16, 2022
@zemyblue zemyblue deleted the revert_tm-db branch December 16, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnasu tnasu tnasu approved these changes

@loloicci loloicci loloicci approved these changes

@shiki-tak shiki-tak Awaiting requested review from shiki-tak

@da1suk8 da1suk8 Awaiting requested review from da1suk8 da1suk8 is a code owner

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zemyblue @CLAassistant @tnasu @loloicci