Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge two workflows into one #132

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

170210
Copy link
Contributor

@170210 170210 commented Oct 19, 2023

Description

This PR merges deploy_to_git and release workflows into one, as both workflows are triggered by the same situation and the release workflow should work after the deploy_to_git workflow.

The logic of the workflow will be as follows:

  • If the pusher is a user, it will first check whether the shared library is the latest version.
    • If it is the latest version, it will start the release workflow.
    • If it is not the latest version, it will update the shared library and stop after creating a PR.
  • If the pusher is a bot, it will start directly from the release workflow.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@170210 170210 requested a review from zemyblue October 19, 2023 08:11
@170210 170210 self-assigned this Oct 19, 2023
@loloicci
Copy link
Contributor

loloicci commented Oct 26, 2023

I think this PR's target is making "pushing tag work" running only when the shared library is the latest.
And, is this workflow's logic according to this rule? Is the pusher's info needed in "if" section?

@170210
Copy link
Contributor Author

170210 commented Oct 26, 2023

I think this PR's target is making "pushing tag work" running only when the shared library is the latest.

I think this PR can do this.

Is the pusher's info needed in "if" section?

I don't think so.
Currently, the workflow will firstly check the pusher.

@loloicci
Copy link
Contributor

I think this PR can do this.

OK, then please write it in the description.

If the the shared library is the latest, the sample will like

missing url. After I look it, I will approve.

@170210
Copy link
Contributor Author

170210 commented Oct 26, 2023

not the missing, just because I am preparing the workflow...

@170210 170210 requested a review from loloicci October 26, 2023 10:47
@170210 170210 merged commit 70d28be into Finschia:main Nov 7, 2023
10 checks passed
@170210 170210 deleted the merge_workflows branch November 7, 2023 08:10
@finschia-auto-pr finschia-auto-pr bot mentioned this pull request Nov 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants