Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add an integration test for ClearAdmin #76

Merged
merged 13 commits into from
Aug 23, 2023
Merged

Conversation

170210
Copy link

@170210 170210 commented Aug 16, 2023

Description

This PR adds an integration test for ClearAdmin.

This test is based on https://github.com/CosmWasm/wasmd/blob/a2373f019ddf34b08bf16ba035f299e119291e66/x/wasm/keeper/msg_server_integration_test.go#L678.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. (not need)
  • I have updated the documentation accordingly. (not need)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not need)

@170210 170210 changed the title Clearadmin test: add an integration test for ClearAdmin Aug 16, 2023
@170210 170210 self-assigned this Aug 16, 2023
@170210 170210 marked this pull request as ready for review August 16, 2023 08:14
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #76 (98bacd4) into main (36ce1d3) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   63.37%   63.51%   +0.14%     
==========================================
  Files          80       80              
  Lines        9994     9994              
==========================================
+ Hits         6334     6348      +14     
+ Misses       3337     3320      -17     
- Partials      323      326       +3     

see 1 file with indirect coverage changes

Kynea0b
Kynea0b previously approved these changes Aug 18, 2023
Signed-off-by: 170210 <[email protected]>
@Kynea0b
Copy link

Kynea0b commented Aug 21, 2023

If you don't need to deal with the items in the checklist, please describe it.

Kynea0b
Kynea0b previously approved these changes Aug 22, 2023
@loloicci
Copy link

LGTM

Signed-off-by: 170210 <[email protected]>
Kynea0b
Kynea0b previously approved these changes Aug 23, 2023
dudong2
dudong2 previously approved these changes Aug 23, 2023
@170210 170210 merged commit 025a70b into Finschia:main Aug 23, 2023
12 checks passed
@170210 170210 deleted the clearadmin branch September 7, 2023 04:28
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants