Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cli_test error of wasmplus #52

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jun 10, 2023

Description

  • fix cli_test error of wasmplus
  • add cli_test and race in github action

Motivation and context

We did not know the cli_test of wasmplus module had error. Because there is not in the ci as test.
So, I fix this problem for adding to ci.

The error is below

$ go test -tags="norace" ./x/wasmplus/client/testutil/...
--- FAIL: TestIntegrationTestSuite (0.01s)
    suite.go:61: 
                Error Trace:    /Users/zemyblue/Documents/project/blockchain/linkchain_v2/wasmd/x/wasmplus/client/testutil/suite.go:61
                                                        /Users/zemyblue/go/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:154
                                                        /Users/zemyblue/Documents/project/blockchain/linkchain_v2/wasmd/x/wasmplus/client/testutil/cli_test.go:32
                Error:          Received unexpected error:
                                unknown field "instance_cost" in types.Params
                Test:           TestIntegrationTestSuite
FAIL
FAIL    github.com/Finschia/wasmd/x/wasmplus/client/testutil    0.434s
FAIL

How has this been tested?

$ make test-integration

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Jun 10, 2023
@zemyblue zemyblue added bug Something isn't working ci labels Jun 10, 2023
@zemyblue zemyblue changed the title ci: add cli_test and race in github action fix: fix cli_test error of wasmplus Jun 10, 2023
loloicci
loloicci previously approved these changes Jun 12, 2023
Makefile Outdated Show resolved Hide resolved
@zemyblue zemyblue merged commit 0a1d457 into Finschia:main Jun 16, 2023
@zemyblue zemyblue deleted the feat/cli_test branch August 8, 2023 09:40
@zemyblue zemyblue mentioned this pull request Aug 31, 2023
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants