Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compile error when the build_tags is multiple. #236

Merged
merged 2 commits into from
Jul 13, 2023
Merged

fix: compile error when the build_tags is multiple. #236

merged 2 commits into from
Jul 13, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 13, 2023 •
edited
Loading

Description

I made a bug in #221. Fix this.
The fnsad binary will not be built if there are multiple build_tags.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@zemyblue zemyblue marked this pull request as draft July 13, 2023 10:55
@zemyblue zemyblue self-assigned this Jul 13, 2023
@zemyblue zemyblue marked this pull request as ready for review July 13, 2023 11:03
@zemyblue zemyblue merged commit 21a120e into Finschia:main Jul 13, 2023
23 checks passed
@zemyblue zemyblue deleted the feat/fix_complie_error branch July 13, 2023 11:16
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@170210 170210 170210 approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

@dudong2 dudong2 Awaiting requested review from dudong2

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

@loin3 loin3 Awaiting requested review from loin3

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zemyblue @loloicci @170210