Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply ibc-go #140

Merged
merged 2 commits into from
Feb 13, 2023
Merged

feat: apply ibc-go #140

merged 2 commits into from
Feb 13, 2023

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Feb 10, 2023

Description

apply line/ibc-go
closes: #135

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@dudong2 dudong2 added the enhancement New feature or request label Feb 10, 2023
@dudong2 dudong2 self-assigned this Feb 10, 2023
@dudong2 dudong2 marked this pull request as ready for review February 10, 2023 10:37
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add IBCChannel and Transfers in wasm.NewKeeper

app.WasmKeeper = wasm.NewKeeper(
		appCodec,
		keys[wasm.StoreKey],
		app.GetSubspace(wasm.ModuleName),
		app.AccountKeeper,
		app.BankKeeper,
		app.StakingKeeper,
		app.DistrKeeper,
		nil, // -> app.IBCKeeper.ChannelKeeper
		nil, // -> app.IBCKeeper.PortKeeper
		scopedWasmKeeper,
		nil, // -> app.TransferKeeper
		app.MsgServiceRouter(),
		app.GRPCQueryRouter(),
		wasmDir,
		wasmConfig,
		supportedFeatures,
		wasmOpts...,
	)

@zemyblue zemyblue mentioned this pull request Feb 10, 2023
3 tasks
@zemyblue zemyblue requested a review from ulbqb February 10, 2023 12:49
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 3c72e21 into main Feb 13, 2023
@dudong2 dudong2 deleted the dudong2/feat/apply-ibc-go branch February 13, 2023 03:08
@loin3 loin3 mentioned this pull request Mar 16, 2023
@zemyblue zemyblue linked an issue Mar 28, 2023 that may be closed by this pull request
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply detached line/ibc-go add lbm's ante_handler
3 participants