Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update golang version to 1.20 #1043

Merged
merged 10 commits into from
Jul 25, 2023
Merged

build: update golang version to 1.20 #1043

merged 10 commits into from
Jul 25, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 18, 2023

Description

closes: #1024

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: CI label Jul 18, 2023
@0Tech 0Tech self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1043 (64d6b8a) into main (73cf295) will increase coverage by 0.01%.
The diff coverage is 70.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   62.01%   62.02%   +0.01%     
==========================================
  Files         656      656              
  Lines       78937    78937              
==========================================
+ Hits        48950    48961      +11     
+ Misses      27298    27287      -11     
  Partials     2689     2689              
Impacted Files Coverage Δ
crypto/keyring/keyring.go 58.07% <0.00%> (ø)
x/foundation/client/testutil/tx.go 100.00% <ø> (ø)
x/foundation/codec.go 100.00% <ø> (ø)
x/foundation/keeper/internal/keys.go 98.11% <ø> (ø)
x/foundation/keeper/internal/msg_server.go 87.20% <ø> (ø)
x/foundation/msgs.go 67.80% <ø> (ø)
x/foundation/foundation.go 84.30% <9.09%> (ø)
x/foundation/keeper/internal/migrations.go 50.00% <33.33%> (ø)
x/auth/keeper/grpc_query.go 57.14% <62.50%> (ø)
x/auth/keeper/keeper.go 74.78% <86.66%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

@0Tech
Copy link
Collaborator Author

0Tech commented Jul 19, 2023

I MUST revert the replace on ostracon.

@0Tech 0Tech marked this pull request as ready for review July 21, 2023 03:46
crypto/keyring/keyring.go Show resolved Hide resolved
snapshots/manager_test.go Show resolved Hide resolved
store/rootmulti/snapshot_test.go Show resolved Hide resolved
@0Tech
Copy link
Collaborator Author

0Tech commented Jul 24, 2023

Or, we should merge #1025 into main and deal with the differences between 1.19 and 1.20.

What do you think @zemyblue ?

@0Tech 0Tech requested a review from zemyblue July 24, 2023 03:36
@zemyblue
Copy link
Member

Or, we should merge #1025 into main and deal with the differences between 1.19 and 1.20.

What do you think @zemyblue ?

No I think it's not a good idea.

@0Tech 0Tech merged commit 43555be into Finschia:main Jul 25, 2023
36 checks passed
@0Tech 0Tech deleted the golang branch July 25, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update golang version
3 participants