Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply the changes from release v0.47.x branch #1035

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jul 4, 2023

Description

apply the changes from release v0.47.x branch

This PR replace #1006 . Because #1006 PR has patch commit from main branch, so it overwrite original commit. And it also have confliction.

👉 I did not update changelog because this is just patch pr. Each commits have each changelogs. So I want to apply each changelog in main branch.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

0Tech and others added 2 commits July 4, 2023 20:45
* Remove relevant messages from proto

* Remove relevant logics from x/foundation

* Use x/param

* Add migration logic

* Update docs

* Update CHANGELOG.md

* Update x/foundation/foundation.go

Co-authored-by: zemyblue <[email protected]>

* Revert lint on protos

---------

Co-authored-by: zemyblue <[email protected]>
(cherry picked from commit e9fe906)
* feat: add `NextAccountNumber` query api in cosmos.auth.v1beta1.query proto

* feat: implement query account number in x/auth module

* chore: update changelog.

* fix: line error

* fix: proto function typo

(cherry picked from commit 94b5a52)
@zemyblue zemyblue force-pushed the feat/apply_changes_v0.47.x branch from 73cf295 to a9762dc Compare July 4, 2023 11:48
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1035 (73cf295) into main (d8ceec3) will decrease coverage by 0.03%.
The diff coverage is 71.23%.

❗ Current head 73cf295 differs from pull request most recent head a9762dc. Consider uploading reports for the commit a9762dc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   62.03%   62.01%   -0.03%     
==========================================
  Files         655      656       +1     
  Lines       78960    78937      -23     
==========================================
- Hits        48986    48950      -36     
- Misses      27290    27298       +8     
- Partials     2684     2689       +5     
Impacted Files Coverage Δ
x/foundation/client/testutil/tx.go 100.00% <ø> (ø)
x/foundation/codec.go 100.00% <ø> (ø)
x/foundation/keeper/internal/keys.go 98.11% <ø> (ø)
x/foundation/keeper/internal/msg_server.go 87.20% <ø> (+0.09%) ⬆️
x/foundation/msgs.go 67.80% <ø> (+0.17%) ⬆️
x/foundation/foundation.go 84.30% <9.09%> (-2.53%) ⬇️
x/foundation/keeper/internal/migrations.go 50.00% <33.33%> (+50.00%) ⬆️
x/auth/keeper/grpc_query.go 57.14% <62.50%> (+0.62%) ⬆️
x/auth/keeper/keeper.go 74.78% <86.66%> (+1.78%) ⬆️
simapp/app.go 81.97% <100.00%> (+0.04%) ⬆️
... and 3 more

... and 3 files with indirect coverage changes

@zemyblue zemyblue self-assigned this Jul 4, 2023
@zemyblue zemyblue changed the title fix: apply the changes from release v0.47.x branch feat: apply the changes from release v0.47.x branch Jul 4, 2023
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 616ff41 into Finschia:main Jul 11, 2023
38 checks passed
@zemyblue zemyblue deleted the feat/apply_changes_v0.47.x branch July 11, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants