[1.20.1] BrandonsCore integration

[coaber]

Bug Description

I've noticed that when Draconic Evolution and Embeddium is installed, certain parts of DE's multiblocks (the Draconic Reactor in particular) do not render properly(the reactor core is fully invisible). This is a recurring issue with Rubidium as well, and apparently it has been fixed on a dev branch for 1.18, but never released. This is the issue i posted on rubidium's repo and additionally on their discord support ticket until something was done, apparently it has to do with the rendering library that DE uses, which is CCL.

Reproduction Steps

Have the latest DE/CCL/BC and Embeddium installed on the latest 1.18 branch, on FML 40.2.0, then just run them, issue is persistent no matter how you tweak the video settings, and only ceases when embeddium is removed.

Log File

latest.log

[embeddedt]

Thanks for the report. I looked into it, and it's different from the existing CCL compatibility problems (which are already fixed in Embeddium for 1.18). It turns out that the 1.18 version of DE uses a different mechanism to render the reactor core than 1.16, and the approach it uses cannot work properly with Embeddium without being patched. I opened an issue on their end to track this: Draconic-Inc/BrandonsCore#112

If they don't fix their code, I may provide a patch in Embeddium for this later, but no guarantees.

[FoxMcloud5655]

We'll look into this and see what's feasible.

[embeddedt]

Now that mod compatibility logic is properly separated from the main renderer, it is feasible to apply a patch to BrandonsCore at runtime to resolve this issue. This should be done soon, since 1.18 will likely stop receiving Embeddium updates in the near future.

[embeddedt]

This should be fixed in 0.3.2.

[coaber]

I'm re-opening this thread again, the issue persists on the latest 1.20.1 branch of DE which is currently in testing phase but i'm being told it's due to the fact that the patches may not applied on embeddium 0.3.19 and up.

[FoxMcloud5655]

I said that it could be, not that it was. I don't know the state of Embeddium on Minecraft 1.20.1 all that well, but DE is now in closed testing and the issue does persist.

You can obtain a copy of the latest version on Brandon's discord, or if that's too much trouble, it can wait until the official release of DE.

[embeddedt]

For 1.20.1 it would be ideal for the issue to be fixed more properly on BrandonsCore's end using the approach I suggested in Draconic-Inc/BrandonsCore#112.

[FoxMcloud5655]

I'll bring it up to Brandon, then.

[TedTheTeddo]

Can confirm this is still an issue that is happening on 1.20.1 with embeddium conflict.

[embeddedt]

This will be fixed for 1.20.1 in the next release, by request.

[JohnathanFlake]

Hey i feel bad for asking.

I am bound to 1.18.2. I guess there is no possible way in fixing this issue right?

[embeddedt]

@JohnathanFlake The issue should have already been patched in 0.3.2 and newer on 1.18.2.

Realized this issue is still open; going to close it, as the 1.20.1 patch has now also been released.

[JohnathanFlake]

Sorry, jokes on me used it, with another Extra Mod for Embeddium/Rubidium.

It works. Sorry for bothering