Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Update to react-transition-group #135

Merged

Conversation

jjanssen
Copy link
Contributor

With the release of React 15.5 there are a few add-ons which have been moved to separate repositories. For some it means they are already migrating to its new namespace.

At the moment react-fine-uploader has a peerDependency to the discontinued add-on react-addons-css-transition-group, whereas some projects may already have migrated to react-transition-group namespace. This PR continues on the react-transition-group namespace.

package.json Outdated
"react-addons-test-utils": "15.4.2",
"react-transition-group": "1.2.0",

This comment was marked as spam.

This comment was marked as spam.

@@ -1,6 +1,6 @@
import React, { Component } from 'react'
import PropTypes from 'prop-types'
import ReactCssTransitionGroup from 'react-addons-css-transition-group'
import { CSSTransitionGroup } from 'react-transition-group'

This comment was marked as spam.

@jjanssen jjanssen force-pushed the feature/react-transition-group branch from 67dda03 to fad6636 Compare July 19, 2017 21:00
@jjanssen
Copy link
Contributor Author

Thanks for reviewing, I have updated the PR with your feedback.

When I originally started the PR react-transition-group only had a v1 out, which they have now replaced with a refactored v2. If there are dependencies on v2 it would probably more relevant for a major release.

@jjanssen
Copy link
Contributor Author

Ah it seems like travis uses the dependencies for the testsuite. Would it be more relevant to add it to the devDependencies. Any thoughts on that matter?

@JeffreyATW
Copy link

Would you mind updating this branch? Interested in getting this to work with React 16!

@rnicholus rnicholus merged commit 6e6d7c8 into FineUploader:master Sep 28, 2017
@rnicholus
Copy link
Member

Thanks for the reminder @JeffreyATW. Released to npm as v1.0.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants