This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
set default content-type for uploads #1846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the browser can't figure out a content-type, set a generic one, to avoid policy errors on missing content-type.
6 tasks
|
Really having trouble believing that this is necessary. The S3 upload code has been around for years, and this is the first time the issue has surfaced. |
|
Thanks for the feedback. I've confirmed that this change isn't necessary with AWS S3. I'll pursue it with the Ceph/radosgw people. Would you be amenable to carrying this as a disabled-by-default feature, e.g. "enable_sending_default_content_type"? |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the browser can't figure out a content-type, set a generic one, to avoid policy errors on missing content-type.
Brief description of the changes
This fixes #1841
What browsers and operating systems have you tested these changes on?
Tested with Chrome 58 on Linux and Ceph/radosgw/s3 10.2.3
Have you written unit tests? If not, explain why.
Don't know how :( but willing to learn...