feat: rewrite color system #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each ColorFormatRow now handles it's own color/display/parsing, allowing us to remove the ugly callbacks.
Also fixes an issue, where the default window size would be reset to the largest size upon startup.
For this, the name source dialog is integrated as a sub page and the illuminant settings have been removed.
This avoids creating and adding a new CSS snipped for each color in the history.
Implements a new bottom sheet, that allows changing the picked color via custom HSL scales.
This word describes the bar of a scale, but is not reconginzed by the spell checker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the color system to use palette instead of a homegrown color system. The new color system also enables us to remove the palette dialog and replace it with a new EditBottomSheet, allowing the user to modify the color.
Closes #80, #101