Skip to content

o-banner: Improve link descriptions for use with screen readers - ID: DAC_Non_Descriptive_Links_01 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #498
JakeChampion opened this issue Jan 6, 2022 · 1 comment · Fixed by #607
Labels
accessibility An accessibility issue

Comments

@JakeChampion
Copy link
Contributor

Issue

This is from page 23 of the audit report

Issue can be found on: https://www.ft.com/__origami/service/build/v3/demo?component=o-banner%404.0.0&demo=banner&system_code=origami-repo-data&brand=master

The ‘Try it now’ and ‘Give feedback’ links are non-descriptive for screen reader users navigating out of the context of the page using the links dialog list.

Screen reader user comments:

There are two links on this page that are unclear when navigated to out of context. Using the ‘U’ keystroke or the JAWS Links dialogue (Insert + F7) I found ‘Try it now’ and ‘Give feedback’.
Neither of these links describe what they refer to, this means that Screen Reader users will be at a loss until they activate the links.
Including clear and descriptive link text such as ‘Try new homepage’ should help to clarify the purpose of links.”

Proposed Solution:

Add more description to the links, this can be by adding to the visual link text or with visually-hidden text. This will enable screen reader users to identify the purpose of the links when navigating out of the context of the page.
Example:

<a href=”#” class=”o-banner__button”>Try the new homepage</span></a> CSS:
 <a href=”#” class=”o-banner__link”>Give feedback<span class=”visually-hidden”>on the new homepage</span></a>
.visually-hidden {
	clip: rect(0 0 0 0);
	clip-path: inset(50%); 
	height: 1px; 
	overflow: hidden; 
	position: absolute; 
	white-space: nowrap; 
	width: 1px;
}
@notlee
Copy link
Contributor

notlee commented Jan 10, 2022

Note. This and similar issues apply to Stories. We should updated Story default props to also be descriptive.
#523

@JakeChampion JakeChampion changed the title o-banner: Improve link descriptions for use with screen readers o-banner: Improve link descriptions for use with screen readers - ID: DAC_Non_Descriptive_Links_01 Jan 11, 2022
JakeChampion added a commit that referenced this issue Feb 3, 2022
…users who navigate to the links out of context by use of Jaws or other similar software

Resolves: #502
JakeChampion added a commit that referenced this issue Feb 3, 2022
…users who navigate to the links out of context by use of Jaws or other similar software

Resolves: #502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility An accessibility issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants