-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CI-342 Remove topper mapping logic (#59)
* Move logic determining which topper to apply The logic determining which topper to apply to an article has been moved from `o-topper` and into it's own library, `n-map-content-to-topper`. We've done this so we can use the `mapContentToTopper` helper on the server-side in `next-article`. Also, it moves us closer to having `o-topper` less tied to Customer Products content. * Update support status to `maintained` Now that the App and FT.com will be using this component, we can update the status from `experimental` to `maintained`. * Bump version of `n-map-content-to-topper` The new version of `n-map-content-to-topper` makes it available on Bower, see https://github.com/Financial-Times/n-map-content-to-topper/releases/tag/v1.1.0. * add n-map-content-to-topper as bower dep * Use Bower package name via Jake: > This needs to be written using the bower package name which is not namespaced. When it gets published to npm, Origami uses a tool to convert the imports into their npm equivalent. * Remove image credit from failing demos To unblock the release, we are temporarily removing the image credit from the news package demo. This decision was made after a conversation between myself, @GlynnPhillips and @notlee. We're temporarily removing rather than fixing because in attempting to fix it, the problem spiralled out of control. We think there is a bigger discussion to be had about `o-toppers` and it's something Content Innovation would like to look at after the new live blogs has launched. * Update package.json No longer needed because it's added by the Origami Component Converter Co-authored-by: Jake Champion <[email protected]> Co-authored-by: chee <[email protected]>
- Loading branch information
1 parent
68d2d30
commit 1f30897
Showing
8 changed files
with
13 additions
and
462 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import mapContentToTopper from './src/js/map-content-to-topper.js'; | ||
import mapContentToTopper from 'n-map-content-to-topper'; | ||
|
||
export { mapContentToTopper }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ | |
"email": "[email protected]", | ||
"slack": "financialtimes/ft-origami" | ||
}, | ||
"supportStatus": "experimental", | ||
"supportStatus": "maintained", | ||
"browserFeatures": { | ||
"required": [], | ||
"optional": [] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.