Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci 1165 replace podcast description with standfirst #32

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Ci 1165 replace podcast description with standfirst #32

merged 2 commits into from
Oct 13, 2022

Conversation

AliceArmstrong
Copy link
Contributor

@AliceArmstrong AliceArmstrong commented Oct 12, 2022 •
edited
Loading

Ticket.

This PR:

  • Changes the description used for podcast toppers from 'byline' to 'standfirst'
  • Updates the tests

Before:
Screenshot 2022-10-12 at 12 51 45

After (ft.com):
Screenshot 2022-10-12 at 12 51 37

After (app):
Screenshot 2022-10-12 at 12 51 57

@AliceArmstrong AliceArmstrong requested a review from a team as a code owner October 12, 2022 11:55
@AliceArmstrong AliceArmstrong merged commit ef9d680 into main Oct 13, 2022
@AliceArmstrong AliceArmstrong deleted the CI-1165-replace-podcast-description-with-standfirst branch October 13, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyewale boyewale boyewale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliceArmstrong @boyewale