Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Page Kit compatible with the latest version of handlebars #596

Closed
magsallen opened this issue Sep 24, 2019 · 1 comment
Closed

Make Page Kit compatible with the latest version of handlebars #596

magsallen opened this issue Sep 24, 2019 · 1 comment
Labels
Bug Something isn't working Housekeeping Mainly repo maintenance Server-side integration

Comments

@magsallen
Copy link
Contributor

Handlebars released a new version, v4.3.0, today which throws type errors in Page Kit.

 src/PageKitHandlebars.ts(123,36): error TS2345: Argument of type '{ helpers: { [key: string]: HelperDelegate; }; partials: { [x: string]: TemplateDelegate<any>; }; }' is not assignable to parameter of type 'RuntimeOptions'.
- 
    Property 'allowCallsToHelperMissing' is missing in type '{ helpers: { [key: string]: HelperDelegate; }; partials: { [x: string]: TemplateDelegate<any>; }; }' but required in type 'RuntimeOptions'.
- 
  npm ERR! code ELIFECYCLE

As a temporary fix, the dotcom-server-handlebars package will be pinned to "handlebars": "4.2.1" but a more permanent solution is needed.

@magsallen magsallen added Bug Something isn't working Server-side integration labels Sep 24, 2019
binaryberry added a commit that referenced this issue Sep 24, 2019
Handlebars released a new version, v4.3.0, today which throws type errors in
Page Kit. #596
@i-like-robots
Copy link
Contributor

i-like-robots commented Sep 24, 2019

Fixed in #597.

It seems there may be multiple issues with v4.3.0 so it's probably best we stick to v4.2.x anyway.

@i-like-robots i-like-robots added the Housekeeping Mainly repo maintenance label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Housekeeping Mainly repo maintenance Server-side integration
Projects
None yet
Development

No branches or pull requests

2 participants