Repository navigation
w748: accounts list shows only accounts in use; vault entries renamed vault-<person>[-<n>] - #247
Merged
Merged
Conversation
… vault-<person>[-<n>] An account is listed only when a role or machine is set to use it or an agent runs on it (a machine on the vault hides its own login). A vault token loses the "vault:" prefix and its description; the usage line says "from rate limits". The host sync names entries vault-<person>[-<n>]; fffctl vault put renames the old host-... entry holding the same token. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…daemon runs on the portal's own host Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accounts list (dashboard and
system_status"Claude accounts in use",buildAccounts)inUseinAccountContext,hostAccountsInUseinserver/secrets.ts,index.tsaccountsNow):machines.claudeFromVault(or on the host token,useHostClaudeEnv); it returns when the machine leaves the vault;claudeAccountsis set to"login"and a host token exists;"vault";vault-lothsahn-1 …EAAA(novault:prefix); its description ("the token vault: workers, standing on every machine…") is gone; the dashboard's "N agents" andsystem_status's "agents on it: …" stay. Machine logins keep "m3 login".Rename, end to end
deploy/vm/host/vault.shnow names entriesvault-<person>(claude-token),vault-<person>-<n>(claude-tokens/),vault-<person>-github(kept in the same scheme so everything the sync manages starts withvault-).fffctl vault put --name vault-ben-1finds thehost-…entry holding the same token and renames it (Vault.rename, alsofffctl vault rename OLD NEW): id, token, owner, grants, meters and sessions' last pick stay. A sync against a portal that cannot rename yet changes nothing and warns; an old entry is never removed while its file exists; one left beside its new entry (file changed meanwhile) is removed. Two files that would make one name: the first wins, the other is warned.host-names (ownership is the entry'sowner), so only the sync, the CLI, docs and tests change.Workers role on the portal host (added by Lothsahn, w748): since w510 the portal runs no workers, so
claudeAccounts.workersapplies only if a worker daemon runs on the portal's own host (a machine addedlocal). With none, the " login (workers)" account row, "workers here: …" in the per-agent line and the "WARNING: set to the login (workers), which cannot run agents" are left out (workersHere,shownRoles(cfg, workersHere),hostAccountsInUse(cfg, workers)); they return when a local machine is added. Test:accounts.test.tsboth cases.Docs: docs/vault.md (3b), docs/accounts.md. Tests:
usage.test.ts(hiding rule both ways, live session keeps it, noinUse= as before, status line),vault.test.ts(rename, CLI put/rename, no value in output),fff-vault-sync.test.sh(rename, old portal, changed file, name clash),ci-vm-e2e.sh(new names).No portal deploy: the dashboard part is live when Lothsahn deploys; the entries rename at the next
fff-vm vault-syncafter that.Request: w748
🤖 Generated with Claude Code