Repository navigation
w743: the ops worker may run fffctl units and units --check (read only) - #243
Merged
Merged
Conversation
…ead only) through fff-ops-priv Request: w743 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ord has its own check) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request: w743
lothsahn: "Please make it so you can run sudo fffctl units --check"
What
deploy/vm/guest/fff-ops-priv: newunitssubcommand, exactlyunitsandunits --check(→fffctl units [--check]as root, exit status passed through). Any other word or extra token exits 2 before fffctl runs. No watchdog, restart, pause or reset.server/opsWorker.ts:unitsadded toOPS_FFFCTL(the shell guard refusedfffctl unitsas "a person's": that was the refusal the worker saw) and to the worker's prompt. The worker typesfffctl units --check; its guard still refusessudo.deploy/vm/test/fff-ops.test.sh: allowed forms, exit-1 passthrough, and 19 refused forms (units --fix,units --check extra, watchdog run/pause/resume/reset, restart…).server/opsWorker.test.ts: guard cases.docs/ops-worker.md: new row in the "It may" table and the deploy note.Evidence
node --test server/opsWorker.test.ts13/13 pass,tsc -p .clean. The new fff-ops.test.sh block ran green on macOS against a root-check-free copy of the guard (the full script needs root/Linux; CI runs it as root).fffctl unitson the VM (read-only, unchanged).Deploy
Scripts + server only; sudoers unchanged (still one root file,
fff-ops-priv). A portal deploy (fffctl update) carries it; the hostinstall.sh --guest-onlyis not needed. Merging before or after the vault cut-over does not matter for that install.