Skip to content

w694: delegated requests let workers merge obvious-bug and tests-only PRs - #234

Merged
bryding merged 1 commit into
mainfrom
w694-delegation-merge
Oct 8, 2026
Merged

bryding merged 1 commit into
mainfrom
w694-delegation-merge

Conversation

@bryding

@bryding bryding commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Request: w694

The constraints every standing-agent delegation adds (delegationConstraints, server/orchestrators.ts) told the worker "do not merge it yourself: a person's merge is the review of an agent's request". w687, w688 and w689 (the nightly regression sentry's auto-approved checks; game PRs #1252, #1254, #1255) held green PRs for hours.

What changed

  • The hold is gone. Per Ben (2026-10-08, "as long as they were obvious bugs merging is fine from sentry investigations") the text now says: merge your own PR into develop on green CI and verification when it fixes a clear, demonstrated bug (failing-first test or reproduction) or only adds tests or verdicts; a PR that changes design or behaviour beyond the bug is a judgement call, left open for a person and said so in the report.
  • Kept: PR into develop, never master/main, never push to develop directly, never force-push; money, publishing, live settings, releases and deploys still need a person in their own words.
  • Why the guard existed: an agent's task text may come from outside the team. It covered auto-approved delegations too (the failing case), so it cannot be kept "only for unapproved ones"; the narrowing to obvious bugs is Ben's.
  • Dispatcher and orchestrator prompts already say workers merge their own PRs (MERGE_RULES, server/agents.ts); they do not repeat the delegation hold, so nothing to align there. Docs updated: docs/orchestrators.md, docs/standing-agents.md, CHANGELOG.

Tests

  • New w694: a delegated request lets its worker merge a clear bug fix... (both cases, no blanket ban, person-only gates kept); the w527 end-to-end test now asserts the worker's brief carries the new text.
  • tsc -p . clean; server/orchestrators.test.ts 61/61. Full npm test: 1183/1185; the 2 failures differ between runs and the unchanged base also fails 2 other timing tests under load (flaky, not this change).

Needs a portal deploy (not done here).

🤖 Generated with Claude Code

… PRs

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant