This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Update to support the viewkey encodings in zcash/zips/#117#8
Merged
FiloSottile merged 3 commits intoFiloSottile:masterfrom Feb 23, 2017
Merged
Update to support the viewkey encodings in zcash/zips/#117#8FiloSottile merged 3 commits intoFiloSottile:masterfrom
FiloSottile merged 3 commits intoFiloSottile:masterfrom
Conversation
str4d
reviewed
Feb 23, 2017
| prfAddr(viewKey, key, 1) | ||
| viewKey := make([]byte, 64) | ||
| prfAddr(viewKey, key, 0) | ||
| prfAddr(viewKey[32:], key, 1) |
There was a problem hiding this comment.
Per sections 4.2 and 5.4.6 of the Zcash spec, the output of prfAddr(_, key, 1) needs to be clamped to a valid Curve25519 secret key in order to match the definition of sk_enc. I'm guessing this was unnecessary in askToPKenc() because curve25519.ScalarBaseMult() performs clamping internally.
Contributor
Author
|
Updated the implementation. Wasn't sure if I want to always clamp the output of PRF(1) or just clamp when generating a viewing key. Went with the latter but could easily do the former. |
Owner
|
Perfect, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a specification for serialized viewing keys. Updated to conform to it.
zcash/zips#117