Added Python 3 compatibility#7
Closed
balloob wants to merge 31 commits into
Closed
Conversation
Use argparse for command line Convert command line to console_scripts entry_point PEP8 everything
Is now a proper python library for long running use Command line is converted to use this
All writing is happening in either Device or Structure classes
DRY up Device/Structure a bit
Prevent username/password from being on the ps line
Allow the access_token (and other auth data like URLS) to be cached inbetween calls. Makes calling from one shot scripts faster and more better.
When using the cached data, make sure to call the auth_callback
Helps to ensure precision
Celsius units can't be set via config file because of hard-coded default after the config is read in. Move hard-coded default to the initialization of the dictionary, and update the dictionary based on the config file.
Improve handling of 'celsius' option via config
Convert all temperatures as displayed by show to the selected scale (C/F)
Update install section of README to perform local fork based install as pip will always install an older version
Apply temperature scales to show option
Added functionality to set the target humidity with either a specified
value, or by auto-selecting an appropriate humidity value based on the
Weather API current temperature. The following auto-selection rules are
used:
Outdoor Temperature (Degrees Fahrenheit) Set
Target Humidity (%)
+40°
45%
+30°
40%
+20° 35%
+10°
30%
0°
25%
-10°
20%
-20° 15%
Target Humidity Functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks for your great work! As we're working on adding Nest support to Home Assistant using your library, it would be great to have it on Pypi with Python 3 support.
Gist of changes:
from __future__ import print_functiontonest.pyand__init__.py.printtoprint()