Skip to content

Conversation

@richard-vd
Copy link
Contributor

@richard-vd richard-vd force-pushed the patch-m1-build branch 2 times, most recently from 943908a to c593129 Compare August 10, 2021 10:38
@uwinx
Copy link

uwinx commented Aug 17, 2021

@richard-vd, any updates on this?

@richard-vd
Copy link
Contributor Author

I don't have write access to this repository to merge this PR and update the bottle, but if you want it working now then I suggest to have a look at the README.md and the recent commit history in my fork: https://github.com/richard-vd/homebrew-musl-cross.

@FiloSottile
Copy link
Owner

Like @richfelker in richfelker/musl-cross-make#129 (comment), I suspect the patches are right, and I believe they build a Hello World fine, but I would feel more confident pulling something with a solid justification or a backport from the GCC tree. Has upstream not fixed this yet?

@richfelker
Copy link

I doubt it breaks anything at runtime, but if it's not correct it could break building the toolchain for different hosts. That's why I'd like to see an explanation.

@uwinx
Copy link

uwinx commented Aug 22, 2021

Can confirm that using formula from this PR works for me.

@richard-vd
Copy link
Contributor Author

Updated commit to include patch for gcc-10.3.0.

@DirectorX
Copy link

Any updates? Can I help somehow?

@FiloSottile
Copy link
Owner

Have these patches made it into upstream? If not, why? I do believe that they work when tested, but I am trying to understand why we don't have an official upstream patch to backport.

@richard-vd
Copy link
Contributor Author

Last month this was committed to gcc master: gcc-mirror/gcc@834c8749

I will update the PR to use this patch instead.

@FiloSottile
Copy link
Owner

Awesome, thank you!

@richfelker
Copy link

Thanks! Updating the PR to use the official fix will be much appreciated, and suffices to document that it's a reasonable solution.

@FiloSottile
Copy link
Owner

@richard-vd friendly ping, do you want to import the new patch or should I go ahead with it?

@richard-vd
Copy link
Contributor Author

I redid the Apple silicon patches for gcc-6.5.0 .. gcc-10.3.0 using commits from gcc upstream.

The URL of this patch points to today's commit in richfelker/musl-cross-make#129. I hope both PRs can be merged now.

@ismail
Copy link

ismail commented Mar 3, 2022

@FiloSottile Friendly ping… richfelker/musl-cross-make#129 looks like it will not be merged soon, could you merge this one?

@FiloSottile
Copy link
Owner

Ah, yes, thank you for syncing with upstream!

@FiloSottile FiloSottile merged commit 8d48bcf into FiloSottile:master Mar 3, 2022
@ismail
Copy link

ismail commented Mar 4, 2022

All the glory to @richard-vd , thanks for taking time to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apple silicon support?

6 participants