Some security relevant comments #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZenGround0 But where are we changing the value to 150 ? Shouldn't this PR also change the deployment scripts to change it to 150 instead of 1 ? |
lucaniz
reviewed
Dec 12, 2024
src/PDPVerifier.sol
Outdated
| // and forking attacks are unrelated to biasability, hence challengeFinality = 1 is a safe value. | ||
| // Given a small enough challengeFinality an SP can run several trials of challenge sampling and | ||
| // fork around samples that don't suit them, grinding the challenge randomness. | ||
| // For the filecoin L1, a safe value is 150. |
There was a problem hiding this comment.
// We are setting here this value at 150, as in the Filecoin L1 (epochs between PreCommit and ProveCommit for interactive PoRep Sectors)
lucaniz
reviewed
Dec 12, 2024
| // This deviation is bounded by leafCount / 2^256 given a 256 bit hash | ||
| // Assuming a 1000EiB = 1 ZiB network size ~ 2^70 bytes of data or 2^65 leaves | ||
| // This deviation is bounded by 2^65 / 2^256 = 2^-191 which is negligible. | ||
| // If modifying this code to use a hash function with smaller output size |
There was a problem hiding this comment.
i'd add a comment on which is the "standard solution" (i.e. rejection sampling). Best would be to have a quick note on why we are not implementing it
Yes good point |
aarshkshah1992
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@irenegia @lucaniz I think there were some more comments of this sort you wanted to include, could you refresh my memory ?
Closes #81