feat: SimplePDPService: improve the fault record event #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
reviewed
Dec 9, 2024
src/SimplePDPService.sol
Outdated
| faultPeriods += 1; | ||
| } | ||
| if (faultPeriods > 0) { | ||
| emit FaultRecord(faultPeriods); | ||
| uint256[] memory faultedPeriodsList = new uint256[](faultPeriods); |
There was a problem hiding this comment.
I don't think this is good. This event should be constant sized. It is trivial to reconstruct the faultedPeriodsList offchain from constant size. And then there's no issues with the event growing very big when recovering from long standing faults. We should do (provingDeadlines[proofSetId], faultPeriods) or (nextDeadline, faultPeriods)
| @@ -163,25 +163,29 @@ contract SimplePDPServiceFaultsTest is Test { | |||
|
|
|||
| function testFaultWithinOpenPeriod() public { | |||
| pdpService.rootsAdded(proofSetId, 0, new PDPVerifier.RootData[](0), empty); | |||
|
|
|||
There was a problem hiding this comment.
Where are these noisy edits coming from? If we want to include them we should be running a linting check on CI and fix all of them at once.
|
Closing in favour of #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
proofsetIDand the actual faulted deadlines to theFaultRecordEvent.