Fix & clarify all uses of "rawSize" #223
Open
+40
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #221 |
|
Hey @DarkLord017! Seems like there is a lint-check error that needs to be resolved here |
rvagg
reviewed
Oct 17, 2025
src/PDPVerifier.sol
Outdated
Comment on lines
342
to
343
| (uint256 padding, uint8 height,) = Cids.validateCommPv2(tempPieces[resultIndex]); | ||
| tempRawSizes[resultIndex] = Cids.pieceSize(padding, height); |
There was a problem hiding this comment.
@DarkLord017 let's just break this API, I don't see any current obvious users of this function so I don't there's a huge risk here. Remove uint256[] memory rawSizes from the return values. It's redundant, since as you're seeing, it's in the CID which we return.
There was a problem hiding this comment.
It seems that I added this in the first place, #177, so I'm to blame for the naming here. I take responsibility, but also give permission to break this! It never got consumed by the SDK which was the original intention, but with this fix we can start consuming it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how raw piece sizes are calculated and improves clarity in proof fee calculations in the
PDPVerifiercontract. The main changes involve switching to a more accurate method for determining piece sizes and renaming variables for better readability.FIxes #217
Piece size calculation improvements:
tempRawSizesto useCids.pieceSize(padding, height)instead of multiplying leaf counts by 32, resulting in more accurate piece size determination.Proof fee calculation clarity:
rawSizetoproofSizeincalculateProofFee,calculateProofFeeForSize, andcalculateAndBurnProofFeefunctions to clarify that the fee is based on the proof size in bytes, not the raw size.challengeRangerepresents a leaf count and is converted to bytes by multiplying by 32.