Skip to content

Conversation

@wjmelements
Copy link
Contributor

@wjmelements wjmelements commented Aug 27, 2025

Reverts #187
That solution was an alternative to FilOzone/filecoin-services#168 and should not have merged
Currently it breaks the FWSS build.

@FilOzzy FilOzzy added this to FS Aug 27, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Aug 27, 2025
@wjmelements
Copy link
Contributor Author

The approach of #187 and FilOzone/filecoin-services#166 was the opposite of FilOzone/filecoin-services#168

Per that approach, the IPDPProvingSchedule is now the PDPListener:

Error: Compiler run failed:
Error (3656): Contract "FilecoinWarmStorageService" should be marked as abstract.
  --> src/FilecoinWarmStorageService.sol:30:1:
   |
30 | contract FilecoinWarmStorageService is
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation:
  --> lib/pdp/src/IPDPProvingSchedule.sol:11:5:
   |
11 |     function service() external view returns (PDPListener);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@wjmelements wjmelements requested a review from ZenGround0 August 27, 2025 15:41
@wjmelements wjmelements added the bug Something isn't working label Aug 27, 2025
@github-project-automation github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FS Aug 27, 2025
@wjmelements wjmelements merged commit 5b64650 into main Aug 27, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FS Aug 27, 2025
@github-project-automation github-project-automation bot moved this to 🎉 Done in PDP Aug 27, 2025
rjan90 added a commit that referenced this pull request Sep 16, 2025
chore: remove the #187 and #190(revert of 187) from changelog
rjan90 added a commit that referenced this pull request Sep 17, 2025
* chore: prep v2.1.0 changelog

chore: prep v2.1.0 changelog

* chore: remove the #187 and #190(revert of 187) from changelog

chore: remove the #187 and #190(revert of 187) from changelog

* fix: update changelog for PieceCID v2

fix: update changelog for PieceCID v2

* Update CHANGELOG.md

Co-authored-by: Rod Vagg <[email protected]>

* chore: bump version string

chore: bump version string

* chore: update date

chore: update date

* chore: remove CI/CD improvements from changelog

chore: remove CI/CD improvements from changelog

---------

Co-authored-by: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

3 participants