-
Notifications
You must be signed in to change notification settings - Fork 38
Enable insertion of known derivative in autodiff chain #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KristofferC
merged 15 commits into
Ferrite-FEM:master
from
KnutAM:kam/anadiff_in_autodiff
Jan 26, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ddf19b7
Add _insert_gradient function
KnutAM 465a240
Support insert gradient for scalar output functions
KnutAM b4c8d6b
Fix bug: wrong order in double contraction
KnutAM 314f2c6
Simplify creation of a scalar Dual in _insert_gradient
KnutAM 7fbb285
Simplified identification of type info for extracting current gradient
KnutAM 1d705c1
Added support for symmetric tensors and vectors
KnutAM a1a3ab9
made insert_gradient API and added docs
KnutAM eb844b8
Fixed naming on remaining extract_gradient versions
KnutAM a427733
Added insert_gradient example to docs
KnutAM 86e6c1e
Changed API to use @implement_gradient macro
KnutAM bddfeed
Support all types gradient does, add helper functions to clean method
KnutAM f48d2c7
Define open product with/between scalar(s) as regular multiplication
KnutAM 06df357
Fix bugs detected by tests + clean
KnutAM 5093af6
Added tests to @implement_gradient
KnutAM 44cc54e
Improved docs for @implement_gradient
KnutAM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this (and
_insert_gradient) are documented, perhaps remove the underscore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are documented, but I didn't include them in the docs.
(As I documented them before using your @implement_gradient idea).
Should I then remove underscore, include in docs, and export them, or just remove underscore?