Type-stable construction of AbstractValues #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnutAM
commented
Jun 6, 2024
Comment on lines
+156
to
+157
| GradT = shape_gradient_type(fv) | ||
| sdim = GradT === nothing ? nothing : sdim_from_gradtype(GradT) |
Member
Author
There was a problem hiding this comment.
Fixes show of FacetValues with update_gradients=false
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #979 +/- ##
=======================================
Coverage 93.69% 93.70%
=======================================
Files 36 36
Lines 5440 5445 +5
=======================================
+ Hits 5097 5102 +5
Misses 343 343 ☔ View full report in Codecov by Sentry. |
Member
|
Is the Val needed? I tried out this PR without them and it seemed to work anyway (I forgot to comment about it back when I tried). |
Member
Author
|
The Do you have an example where it works without? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves type-stable construction for AbstractValues by introducing the singelton type
ValuesUpdateFlags. In this PR, it is now also possible to have type-stable construction ofCellValues,PointValues, andFacetValueswith custom update specifications by providing kwargs asValtypes. Using booleans still works and remain the documented way, but won't be type-stable.Closes #960