[Feature] --ignore-package Option
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
changed the title
|
Ok, this turned out to not be flexible enough for our needs so I've updated it to a single swift-package-list ElementX.xcodeproj --requires-license --ignore-package element-design --ignore-package element-design-tokens --output-type settings-bundle --output-path ElementX/SupportingFiles |
|
Hey @pixlwave, thanks for your contribution. It def. makes sense to have such functionality, in fact I've used the |
|
Ok nice thanks. No don’t worry, it’s definitely not a big blocker for us - and if we do suddenly need it we can always run from the fork for a while :) |
macOS 14 images removed visionOS: actions/runner-images#10559
FelixHerrmann
approved these changes
Oct 6, 2024
FelixHerrmann
changed the title
--ignore-package option
FelixHerrmann
changed the title
--ignore-package option--ignore-package Option
|
Very nice! Thanks Felix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--ignore-packageoption to the CLI for filtering out specific packages by their identity; to expose this functionality to the SPM plugin there is a new optional"ignorePackages"field in the config.Original message:
Hi, I'm not sure what you look for in a contribution, so opening this as a starting point for discussion.
We're using swift-package-list in our project (really love it, thanks for making this project) and would like a way to filter out our own packages from the generated Acknowledgements. This PR adds the ability to run a command like so
This would ignore any packages who's repository URLs are
https://github.com/element-hq/…Let me know if you would prefer to do this another way, tweak the naming, or if there is more implementation required for this PR to be mergeable.