This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Fixing a bug in fetching session list from files #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fetching session list from files, ignore folders and fetch next available session file instead of returning null. If you happen to have a stray folder in the sessions folder, then the order in which FindNextFile() gets files is uncertain. And often we end up seeing a folder traversed in the middle of several session files. This issue is easily reproducable if we have lots of session files that start with different names and a folder.
|
Anyone up for review? |
FauxFaux
pushed a commit
that referenced
this pull request
Feb 21, 2014
While fetching session list from files, ignore folders and fetch next available session file instead of returning null. If you happen to have a stray folder in the sessions folder, then the order in which FindNextFile() gets files is uncertain. And often we end up seeing a folder traversed in the middle of several session files. This issue is easily reproducable if we have lots of session files that start with different names and a folder.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.
If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.
This issue is easily reproducable if we have lots of session files that
start with different names and a folder.