Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Putty Tray "About button" - version information #135

Closed
NAW77 opened this issue Feb 13, 2014 · 2 comments
Closed

Putty Tray "About button" - version information #135

NAW77 opened this issue Feb 13, 2014 · 2 comments

Comments

@NAW77
Copy link

NAW77 commented Feb 13, 2014

The new builds of Putty have had the About button removed.

Would it not be better to remove the Cancel button as you can use the File>Close or Window "X" to terminate the program (unless it serves another purpose!).
Then you could but the About button back which is useful to find out the software build info.

FauxFaux added a commit that referenced this issue Feb 21, 2014
This, annoyingly, breaks cancelling the dialog with the escape key.
Should this work?  Probably.  Annoying.  Very annoying.  I'm not so
concerned about the problem, as I don't think the help is useful, modern
or actually wanted by most people using it.

Cancellation works by:
 * ssd->cancelbutton->button.iscancel = TRUE;
 * if (ctrl->button.iscancel) actual_base_id = IDCANCEL;
 * When someone presses escape, Windows generates a WM_COMMAND(IDCANCEL)
  * This is not documented anywhere sensible.  Nowhere.  NOWHERE.

Maybe we could hijack the WM_COMMAND before it arrives at the button
handler, or something?  Shrug.
@FauxFaux
Copy link
Owner

Good plan!

Unfortunately, it breaks escape-as-cancel. I'd recommend just deleting the silly help file. See the rant in the commit, or someone can raise a new ticket for fixing this properly.

@NAW77
Copy link
Author

NAW77 commented Feb 27, 2014

Thats a shame. Would it be possible for an About option in the Menu when you click the top left icon (currently you have Move and Close (ALT-F4). Adding the About here would be useful!

If not can the buttons for Keygen/Agent and Help be shrunk to add About back again (also shrunk)?

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants