Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Crash in safefree/ssh_channel_destroy when running ssh-add --invalid in 3f115c6 #123

Closed
ghost opened this issue Dec 21, 2013 · 1 comment
Closed

Crash in safefree/ssh_channel_destroy when running ssh-add --invalid in 3f115c6 #123

ghost opened this issue Dec 21, 2013 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 21, 2013

I have a reproducible crash when:

  • Running putty.exe from 3f115c6
  • Pageant has a key loaded into memory
  • ssh agent forwarding is enabled
  • I run ssh-add --somethinginvalid (any invalid parameter will do)

I have a minidump of the crash but I am unsure if it will contain my keys - please advise.
FauxFaux pushed a commit that referenced this issue Dec 22, 2013
@FauxFaux
GH-123: Fix free of an uninitialised pointer.
067ed10 
CHAN_AGENT channels need c->u.a.message to be either NULL or valid
dynamically allocated memory, because it'll be freed by
ssh_channel_destroy. This bug triggers if an agent forwarding channel
is opened and closed without having sent any queries.

git-svn-id: svn://svn.tartarus.org/sgt/putty@10032 cda61777-01e9-0310-a592-d414129be87e
@FauxFaux
Copy link
Owner

Fixed upstream by 98b9e75; cherry-picked into master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FauxFaux