Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ArrayNode.elements() return ListIterator() #4692

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Make ArrayNode.elements() return ListIterator() #4692

merged 2 commits into from
Sep 11, 2024

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Sep 11, 2024 •
edited
Loading

Resolve #3120

@JooHyukKim JooHyukKim changed the title Resolve #3120 Make ArrayNode.elements() return ListIterator() Make ArrayNode.elements() return ListIterator() Sep 11, 2024
@JooHyukKim JooHyukKim mentioned this pull request Sep 11, 2024
Closed
@cowtowncoder
Copy link
Member

Looks good; could you also add an entry in release-notes/VERSION-2.x? Happy to merge this, thank you @JooHyukKim !

cowtowncoder
cowtowncoder approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@cowtowncoder cowtowncoder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, would like comment & release notes entry, then can go in 2.18(.0).

*EDIT: will make changes, merge.

@cowtowncoder cowtowncoder added this to the 2.18.0 milestone Sep 11, 2024
@cowtowncoder cowtowncoder merged commit d6e3b20 into FasterXML:2.18 Sep 11, 2024
9 checks passed
@JooHyukKim JooHyukKim deleted the resolve3120 branch September 11, 2024 23:34
@JooHyukKim
Copy link
Member Author

approved, would like comment & release notes entry, then can go in 2.18(.0).

*EDIT: will make changes, merge.

I forgot about it. Thanks! 👍🏼

@cowtowncoder
Copy link
Member

@JooHyukKim np! Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
2.18
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

Return ListIterator from ArrayNode.elements()
2 participants
@JooHyukKim @cowtowncoder