Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated publish #61

Merged
merged 1 commit into from
May 22, 2023

Conversation

jjshoots
Copy link
Member

No description provided.

@jjshoots
Copy link
Member Author

Precommit is failing for this as well as master apparently because of some issue with pillow. @ppasupat do you have any clue what is happening?

@pseudo-rnd-thoughts
Copy link
Member

@jjshoots The issue is with pyright, when pyright updates then this should be fine

@ppasupat
Copy link
Collaborator

I think we should add a version number to pyright. Other pre-commit hooks have version numbers specified.
Here is a PR: #62.

@pseudo-rnd-thoughts
Copy link
Member

pseudo-rnd-thoughts commented May 19, 2023

The problem is that pyright has regular updates, about every week. Therefore, we either select a version and have to update periodically or keep master and have to deal with these issues occasionally

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 6c6582a into Farama-Foundation:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants