Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more actions #46

Merged
merged 17 commits into from
Apr 28, 2023

Conversation

ppasupat
Copy link
Collaborator

@ppasupat ppasupat commented Apr 24, 2023

Description

Implemented the missing actions, including:

  • Mouse actions at the specified coordinates (move, double-click, mousedown, mouseup).
  • Scroll wheel (scroll up, scroll down). The scroll amount is specified in the config).
  • Key press, including special keys like "<PageUp>" and combinations like "Ctrl+C". The allowlist of key combinations is specified in the config.
  • Field typing, which directly types the text from a task field (provided it is entirely in ASCII).

The tests and documentation were updated accordingly.

Fixes #27.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and impressive.
Im reminded that after we have completed all of the updates that you are interested are doing, we should reconfirm performance to check that we haven't broken something along the way if this is possible

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 41631d5 into Farama-Foundation:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Implement missing actions
2 participants