Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fields to the observation space. #43

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

ppasupat
Copy link
Collaborator

Description

Added fields to the observation space.

  • Fields are key-value pairs extracted from the utterance. For example, "Click on the OK button" → [("target", "OK")].
  • Fields are represented as a sequence of key-value tuples.

Fixes #29.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are happy with the testing then Im happy with the PR. You understand the project better than I do

@jkterry1 jkterry1 merged commit aeae9ad into Farama-Foundation:master Apr 10, 2023
@ppasupat ppasupat deleted the fields branch April 10, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Put task fields in the observation space.
3 participants